Skip to content

Arm backend: Add support for torch.remainder #15409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

Arm backend: Add support for torch.remainder #15409

merged 3 commits into from
Oct 30, 2025
+208 −2

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Oct 28, 2025 •
edited by pytorch-bot bot
Loading

Add DecomposeRemainderPass to express tensor remainder via floor div, multiplication, and subtraction.

Test plan

Test for the new operator has been added in backends/arm/test/ops/test_remainder.py.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Arm backend: Add support for torch.remainder
80f3712 
Add DecomposeRemainderPass to express tensor remainder via floor div,
multiplication, and subtraction.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: I313d0685bc00839cb2b96ec1976722649a27d4b9
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15409

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 00258c6 with merge base c85ece4 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 28, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

tests fails unrelated, added files are already catched by *.py for buck2

@zingo zingo merged commit d5f5cc2 into pytorch:main Oct 30, 2025
295 of 298 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Oct 30, 2025
@martinlsm @agrima1304
Arm backend: Add support for torch.remainder (pytorch#15409)
66ba13f 
Add DecomposeRemainderPass to express tensor remainder via floor div,
multiplication, and subtraction.

Test for the new operator has been added in
backends/arm/test/ops/test_remainder.py.

Signed-off-by: Martin Lindström <[email protected]>
Co-authored-by: Martin Lindström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinlsm @zingo